Fixes #3148: Python 3.10 Deprecation Warnings #3150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR fixes #3148 |
alecgarza96
changed the title
alecgarza96
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In worker.py, changed the scientific notation 1e10 literal to its equivalent 10000000000 integer literal.
In target.py, removed os.getpid() and time.time() method calls as parameters to random.seed(). Instead, refactored them to be independent variables (processID and currentTime) and passed into random.seed()
Motivation and Context
This change fixes the following warnings that were being received:
luigi/target.py:287: DeprecationWarning: non-integer arguments to randrange() have been deprecated since Python 3.10 and will be removed in a subsequent version
luigi/worker.py:161: DeprecationWarning: Seeding based on hashing is deprecated since Python 3.9 and will be removed in a subsequent version.
Have you tested this? If so, how?
Yes, as these were native python function calls their functionality was tested locally through unit tests