Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin jinja2 version; >3.1 breaks sphinx build #3158

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

dlstadther
Copy link
Collaborator

Description

Pin jinja2 version to avoid error

Motivation and Context

Related to readthedocs/readthedocs.org#9037

doc build failure prevents merge of PRs

Have you tested this? If so, how?

Local doc test and build is passing. Checking remote Github Actions now through PR

@dlstadther dlstadther requested a review from a team as a code owner April 17, 2022 17:31
@dlstadther
Copy link
Collaborator Author

@sonjaer @honnix @ckiosidis @jesperps Could i get an approval here? Currently Github Action tests against master are failing. This resolves them. And i'd like to be able to merge code again with a passing build.

@dlstadther
Copy link
Collaborator Author

Hey @honnix , any chance you can help me out here? Or point me to the right path to identifying an appropriate Spotify employee or Luigi maintainer which i can catch up with?

I realize as Spotify transitions away from Luigi use internally towards Flyte, it will continue to be harder to get Spotify employee attention to this project. Have there been an internal conversation around Luigi support throughout this time?

@dlstadther
Copy link
Collaborator Author

@erikbern , I know you haven't been involved in Luigi in some time, but do you know the best contact within Spotify to help steer the project such that it'll continue to be (minimally) supported although Spotify is moving away from its use?

I may not be doing much here, but still at least trying to keep master decent. However, I can't merge bugfixes by myself.

@honnix
Copy link
Member

honnix commented Apr 27, 2022

Hey @honnix , any chance you can help me out here? Or point me to the right path to identifying an appropriate Spotify employee or Luigi maintainer which i can catch up with?

I realize as Spotify transitions away from Luigi use internally towards Flyte, it will continue to be harder to get Spotify employee attention to this project. Have there been an internal conversation around Luigi support throughout this time?

Sorry I missed the comments. I have not worked very closely with the team but I will let them know. I understand your work load and frustration. We will see how we can make it better.

@erikbern erikbern merged commit 46b28c2 into spotify:master Apr 27, 2022
@erikbern
Copy link
Contributor

If this is what it takes to unbreak master, seems fine to merge!

@dlstadther
Copy link
Collaborator Author

Thanks so much @honnix and @erikbern !

@dlstadther dlstadther deleted the feature/fix-doc-build branch April 27, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants