Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix md5 hash error for FIPS in python 3.9 #3209

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

davidesba
Copy link
Contributor

Description

Add usedforsecurity=False to all md5 hashes to ensure FIPS compatibility in python >= 3.9

Motivation and Context

As python 3.9 documentation for hashlib states:

All hashlib constructors take a keyword-only argument usedforsecurity with default value True. A false value allows the use of insecure and blocked hashing algorithms in restricted environments. False indicates that the hashing algorithm is not used in a security context, e.g. as a non-cryptographic one-way compression function.

Have you tested this? If so, how?

Tested in local project with python 3.11

@davidesba davidesba requested review from dlstadther and a team as code owners November 24, 2022 13:18
Copy link
Collaborator

@dlstadther dlstadther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dlstadther dlstadther merged commit 2ad155a into spotify:master Nov 24, 2022
@mjomora
Copy link

mjomora commented Nov 24, 2022

When will we have this tagged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants