-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Silence false positive UnconsumedParameterWarning #3235
Silence false positive UnconsumedParameterWarning #3235
Conversation
8b621ee
to
6c5a463
Compare
370789a
to
59a3bcd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@andresgomezfrr Do you have any idea how to fix codecov? |
@starhel Could you try to update this branch with master? |
59a3bcd
to
e77375d
Compare
Branch was updated, I've forced CI to retest PR. edit: codecov python package is no longer supported: https://github.com/codecov/codecov-python. |
Do not emit UnconsumedParameterWarning when parameter name is written in camelCase or with dashes.
…ging parameters in core config.
e77375d
to
b877047
Compare
Apologies for not merging this sooner! |
I am using Luigi 3.5.2, the latest. But I still have these warnings! Edit: ignore_unconsumed = {
'autoload_range',
'no_configure_logging',
} but any other parameter still raises these warnings. I ended up solving it as: |
UnconsumedParameterWarning is emitted even if parameters are correctly consumed.
Description
There are two cases when UnconsumedParameterWarning is false positive:
Motivation and Context
False positive UnconsumedParameterWarning forced me to completely disable this feature as any output to stderr is treated as error in pipelines.
Have you tested this? If so, how?
I've added unitests and tested this branch in my pipeline.