Do not escape <br> tags in task tooltips, so that the line breaks are… #3250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a minor formatting fix for the Task popover text in the Dependency Graph tab of the scheduler GUI.
Motivation and Context
With the XSS fix implemented in #3230, the tooltip text for a task with multiple parameters has the line break tags escaped:
This change simply escapes the text for each parameter individually, and then joins the escaped strings with the
tags.
Have you tested this? If so, how?
I spun up a scheduler and checked that a simple test task displays correctly.
