Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add python 3.11 support #3265

Merged
merged 3 commits into from
Dec 17, 2023
Merged

Add python 3.11 support #3265

merged 3 commits into from
Dec 17, 2023

Conversation

ukky17
Copy link
Contributor

@ukky17 ukky17 commented Dec 14, 2023 •
edited
Loading

Description

@ukky17 ukky17 requested review from dlstadther and a team as code owners December 14, 2023 12:42
@ukky17 ukky17 changed the title Add python 3.11 and 3.12 support Add python 3.11 support Dec 14, 2023
dlstadther
dlstadther approved these changes Dec 17, 2023
View reviewed changes
Copy link
Collaborator

@dlstadther dlstadther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only code change (inspect.getfullargspec() is documented to be supported in our lowest (3.6) python version as well.

All CI tests are passing.

Thanks!

@dlstadther dlstadther merged commit b5be147 into spotify:master Dec 17, 2023
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlstadther dlstadther dlstadther approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ukky17 @dlstadther