-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for sqlalchemy 2 and text upgrades #3267
base: master
Are you sure you want to change the base?
Conversation
Hey @dlstadther what can I do to help move this forward? |
Just encountered this issue and was considering making a similar set of changes, glad I didn't! Tried running the tests locally with For now our project can pin an older version of sqlalchemy but it would be lovely to see this PR progress, does your user base have much to lose by dropping python 3.6 support in order to gain sqlalchemy 2.X? It's been end-of-life for a while... |
Looking at https://pypistats.org/packages/luigi , there is virtually no 3.6 usage of luigi. |
Looking back at past releases, we haven't performed a major version increment when dropping a specific minor version of python. |
FYI. I've submitted #3325 |
That's very reassuring to see, thank you |
Description
Quick fix for task history logging and sqlalchemy 2.x
Motivation and Context
Using sqlalchemy 2.x breaks luigid if task history is enabled
e.g.
Results in luigid exiting
This is because sqlalchemy requires a sqlalchemy.text object vs string in conn.execute
Have you tested this? If so, how?
Tested locally with sqlite3 and sqlalchemy 2.0.23 and luigi 3.4.0