Add option to remove event handler from luigi.Task #3282
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'd like to introduce
luigi.Task.remove_event_handler
method to support removing one of registered callbacks. By invoking this method with the appropriate parameters (event and callback), the specified event handler is removed from the internal registry.Motivation and Context
I have many tests in which I need to collect all exceptions from a graph. Since
luigi.build
does not return a list of exceptions, I've discovered that adding an event handler is the simplest way to achieve this. However, there's currently no option to remove the handler in the teardown. As a workaround, I must maintain a hack with a private field of the Task class for now.Have you tested this? If so, how?
Above fixture is utilized in my projects, and I've also added a unittest. :)