Replace os.rename with os.replace #3322
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #2975.
Replace
os.rename
withos.replace
.Motivation and Context
According to the Python documentation,
os.rename
should be avoided for cross-platform compatibility. It is recommended to useos.replace()
.This change ensures that the file move operation works correctly across different filesystems.
On a Windows environment, running the following program twice will result in an error.
Have you tested this? If so, how?
Tested locally.