Allow MIDI messages for all external instrument plugins #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem Some external instrument plugins have audio inputs on the main bus when loaded in pedalboard. This has been observed with AU and VST3 versions of Native Instruments Reaktor 6 and Arturia ARP 2600 V3, for example. When attempting to send MIDI inputs to such plugins, pedalboard throws an error like "ValueError: Plugin '[name]' expects audio as input, but was provided MIDI messages." Solution Instead of using the presence of audio inputs to determine whether a plugin accepts MIDI messages, use the `isInstrument` value from the plugin description object.
|
Unfortunately there are no new tests added here, since I couldn't find any OSS plugins that reproduce this issue - I've only seen it with proprietary ones. I'm happy to add tests if anyone has ideas for how to do so... |
|
This is great - thanks @kmontag! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some external instrument plugins have audio inputs on the main bus when loaded in pedalboard. This has been observed with AU and VST3 versions of Native Instruments Reaktor 6 and Arturia ARP 2600 V3, for example. When attempting to send MIDI inputs to such plugins, pedalboard throws an error like "ValueError: Plugin '[name]' expects audio as input, but was provided MIDI messages."
Solution
Instead of using the presence of audio inputs to determine whether a plugin accepts MIDI messages, use the
isInstrumentvalue from the plugin description object.