Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable linux docker builds on Apple Silicon #47

Merged
merged 9 commits into from
Dec 31, 2021
Merged

Conversation

i
Copy link
Contributor

@i i commented Dec 6, 2021

Currently the output from pip install pedalboard when run from a linux-based docker container running on an Apple Silicon host returns the following error:

ERROR: Could not find a version that satisfies the requirement pedalboard (from versions: none)

This change should fix that error. Please verify this works because I wasn't able to test (not having access to the github actions runner, etc).

@i i changed the title Add aarch64 to linux architectures Enable linux docker builds on Apple Silicon Dec 6, 2021
@psobot
Copy link
Member

psobot commented Dec 6, 2021

Thanks @i! I think this will likely disable the non-aarch64 architectures on Linux - the cibuildwheel documentation suggests adding another step to the GitHub Action job, as well as keeping auto in the list of architectures:

# On an Linux Intel runner with qemu installed, build Intel and ARM wheels
CIBW_ARCHS_LINUX: "auto aarch64"

@psobot psobot linked an issue Dec 30, 2021 that may be closed by this pull request
@psobot psobot self-requested a review December 30, 2021 22:48
@psobot
Copy link
Member

psobot commented Dec 31, 2021

Thanks for kicking this off, @i!

@psobot psobot merged commit 85153d8 into spotify:master Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aarch64 Linux docker images can't install pedalboard from pip
2 participants