Compensate for plugin latency. #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johnxjp
reviewed
Jan 23, 2022
psobot
force-pushed
the
psobot/handle-plugin-latency
branch
from
d43620c to
f09c014
Compare
Johnxjp
reviewed
Jan 24, 2022
Johnxjp
reviewed
Jan 24, 2022
Johnxjp
reviewed
Jan 24, 2022
Johnxjp
reviewed
Jan 24, 2022
drubinstein
reviewed
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have the
PitchShiftplugin, users of Pedalboard need to manually compensate for the latency added when shifting pitch up or down. This PR fixes that by making Pedalboard latency-aware - automatically compensating when a given plugin returns too few samples in a block.