Add GSMFullRateCompressor plugin. #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psobot
force-pushed
the
psobot/gsm-compressor
branch
from
79733b5 to
417697f
Compare
drubinstein
reviewed
Jan 31, 2022
There was a problem hiding this comment.
I'm gonna be a little pedantic. I wouldn't call this a GSMCompressor but a GSMFullRateCompressor (though I'd prefer GSMFullRateEncoder) or allow this plugin to take in an enum which gives the appropriate codec parameters.. GSM supports multiple audio codecs including half rate, enhanced full rate and adaptive multi rate. HR and FR audio sounds incredibly different from each other.
|
Pedantry much appreciated here! I'll add |
|
Then maybe not call it either and label the plugin |
This was referenced Feb 6, 2022
psobot
force-pushed
the
psobot/gsm-compressor
branch
from
6d541f8 to
f000972
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does what it says on the tin: adds a GSM, or "Full Rate" plugin, to make audio sound like it was transmitted over a 2G cell phone. To do this, this PR compiles in
libgsm, a free, open-source, and ISC-licensed GSM encoder/decoder plugin.