Skip to content

fix repl from sbt #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ravwojdyla merged 5 commits into from
Jun 14, 2016
Merged

fix repl from sbt #165

ravwojdyla merged 5 commits into from
Jun 14, 2016

Conversation

@ravwojdyla
Copy link
Contributor

@ravwojdyla ravwojdyla commented Jun 10, 2016

After these fixes - scio shell can be started from both:

  • assembly jar via java -jar <assembly-jar>
  • sbt via sbt run or sbt scio-repl/run

@ravwojdyla ravwojdyla mentioned this pull request Jun 10, 2016
Closed
nevillelyh
nevillelyh reviewed Jun 10, 2016
View reviewed changes
build.sbt Outdated
}
)

lazy val printClasspath = taskKey[Unit]("Dump classpath")
Copy link
Contributor

@nevillelyh nevillelyh Jun 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary or debugging code?

Copy link
Contributor Author

@ravwojdyla ravwojdyla Jun 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only for debugging purposes.

@ravwojdyla
Copy link
Contributor Author

ravwojdyla commented Jun 10, 2016

The seems to be some issue with 2.10 - let me double check.

@ravwojdyla
Copy link
Contributor Author

ravwojdyla commented Jun 10, 2016 •
edited
Loading

Tests are fine and both 2.10 and 2.11 are fine via assembly jar. Sbt launch works with 2.11 but NOT with 2.10 - seems to be related changes between 2.10 and 2.11. Not sure if it's worth to investigate 2.10 more (?)

@codecov-io
Copy link

codecov-io commented Jun 10, 2016 •
edited
Loading

Current coverage is 73.76%

Merging #165 into master will not change coverage

  1. 4 files (not in diff) in .../spotify/scio/values were modified. more
    • Misses -16
    • Hits +16
  2. 3 files (not in diff) in ...om/spotify/scio/util were modified. more
    • Misses -5
    • Hits +5
  3. 3 files (not in diff) in .../com/spotify/scio/io were modified. more
    • Misses -7
    • Hits +7
  4. 2 files (not in diff) in ...ala/com/spotify/scio were modified. more
    • Misses -13
    • Hits +13
  5. 3 files (not in diff) in ...potify/scio/bigquery were modified. more
    • Misses -11
    • Hits +11
  6. File ...o/hdfs/package.scala (not in diff) was modified. more
    • Misses -5
    • Hits +5
  7. File ...gtable/package.scala (not in diff) was modified. more
    • Misses -4
    • Hits +4
@@             master       #165   diff @@
==========================================
  Files            61         61          
  Lines          2100       2100          
  Methods        1921       1932    +11   
  Messages          0          0          
  Branches        179        168    -11   
==========================================
  Hits           1549       1549          
  Misses          551        551          
  Partials          0          0

Powered by Codecov. Last updated by ccd1df4...bb89593

@nevillelyh
Copy link
Contributor

nevillelyh commented Jun 10, 2016

Not worth supporting 2.10 except the potential zeppelin use case but we're not quite there yet.
LGTM except the debugging lines. Remove them?

Rafal Wojdyla added 4 commits June 14, 2016 11:47
Fix scio shell launch from sbt 'run' task
6612a82 
Problem: BQ macros are not expandable.
Run repl on 'run' in root
a572d61
Fix macro expansion in sbt launch mode
348e954
Fix 2.10 issue with scio repl
fecd763 
Problem: scio repl started from sbt is not working properly.
@ravwojdyla ravwojdyla merged commit 5ec30a4 into master Jun 14, 2016
@ravwojdyla ravwojdyla deleted the fix_repl_sbt branch June 14, 2016 22:36
@bzz
Copy link

bzz commented Jul 28, 2016

Sorry for digging this out, but have just came across this: just FYI, as of apache/zeppelin#747 Apache Zeppelin supports Scala 2.11 starting from upcoming 0.6.1 release.

@nevillelyh
Copy link
Contributor

nevillelyh commented Jul 28, 2016

@bzz thanks that's good to know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ravwojdyla @codecov-io @nevillelyh @bzz