Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move class definitions outside package objects #5127

Closed
wants to merge 4 commits into from

Conversation

RustedBones
Copy link
Contributor

@RustedBones RustedBones commented Dec 19, 2023

Class defined in package object create the following warning:

[warn] ...it is not recommended to define classes/objects inside of package objects.
[warn] If possible, define class xxx in package types instead

Moved the class definition outside the package object.

implicit value classes were not affected by warning but to increase consistency across all modules, I created a syntax package and a deprecated type alias in case the value class was used explicitly

@RustedBones RustedBones changed the title Move class definitions outside packages Move class definitions outside package objects Dec 19, 2023
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (1671db7) 63.34% compared to head (76ed9a9) 63.37%.

Files Patch % Lines
.../scio/extra/sparkey/syntax/SCollectionSyntax.scala 89.77% 9 Missing ⚠️
.../main/scala/com/spotify/scio/parquet/Parquet.scala 71.42% 8 Missing ⚠️
...fy/scio/extra/annoy/syntax/ScioContextSyntax.scala 0.00% 4 Missing ⚠️
...scala/com/spotify/scio/extra/sparkey/Sparkey.scala 82.60% 4 Missing ⚠️
...fy/scio/extra/annoy/syntax/SCollectionSyntax.scala 89.65% 3 Missing ⚠️
...ain/scala/com/spotify/scio/extra/annoy/Annoy.scala 77.77% 2 Missing ⚠️
.../scio/extra/sparkey/syntax/ScioContextSyntax.scala 66.66% 2 Missing ⚠️
...ify/scio/extra/json/syntax/ScioContextSyntax.scala 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5127      +/-   ##
==========================================
+ Coverage   63.34%   63.37%   +0.03%     
==========================================
  Files         291      298       +7     
  Lines       10840    10849       +9     
  Branches      753      733      -20     
==========================================
+ Hits         6867     6876       +9     
  Misses       3973     3973              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kellen
Copy link
Contributor

kellen commented Jan 25, 2024

@RustedBones did you end up doing this in another PR or am I hallucinating? if not, should we merge this for 0.14?

@RustedBones
Copy link
Contributor Author

RustedBones commented Jan 26, 2024

No this has never passed CI not been approved, and it's not required for 0.14.
I'm closing this one. Will do another pass to fix warnings later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants