fix(deserializer): try-catch, to prevent parsing non deserializable responses #128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: add try-catch, to prevent parsing non deserializable responses
Problem
Requests answering empty Responses (like Pause Playback) are currently responding non-deserializable content.
This leads to a falsely thrown error.
Solution
I added a try-catch block to DefaultResponseDeserializer#deserialize to prevent the error.
I intentionally did not include logging in the catch-block because the error is falsely thrown.
Result
This only applies to Requests with empty Responses returning non-deserializable content.
It should not break any code