Bump and pin dependencies #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also got rid of "incorrect peer dependency" warnings.
peerDependencies in the packages were throwing warnings, potentially related to yarnpkg/yarn#5810. In this commit, we rework the peerDependency definitions to align better with the conventions outlined in the main peerDependency documentation, and we define devDependencies both at the top level and at the package level, since package-level is technically closer to "correct" but it doesn't satisfy the checks in yarn yet. In addition, we've bumped a few versions and aligned across the packages where duplication occurs, which led to our tests running into jsx-eslint/eslint-plugin-react#2329 for our "detect" mode in eslint-plugin-react.
fastfrwrd
force-pushed
the
bump-and-pin-dev-dependencies
branch
from
2197561
to
eceff7c
Compare
fastfrwrd
reviewed
Jun 26, 2019
| react: { | ||
| version: 'detect', | ||
| }, | ||
| }, |
There was a problem hiding this comment.
caused by updates in eslint-plugin-react; we would have run into this the next time we bumped. Related issue: jsx-eslint/eslint-plugin-react#2329
|
@alde I've pushed the update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also got rid of "incorrect peer dependency" warnings.