Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for cluster roll #279

Merged
merged 6 commits into from
Jan 24, 2024
Merged

Conversation

sharadkesarwani
Copy link
Contributor

Added support for cluster roll.

Jira Ticket

https://spotinst.atlassian.net/browse/SPOTAUT-17448

Corrected attribute name
Modifed `rollspec` struct to support `NodePoolNames`
Copy link
Contributor

@chandra1-n chandra1-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please implement support for list rolls and stop roll as well

Copy link
Contributor

@chandra1-n chandra1-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the review comments

Added support for `ListRolls` and `StopRoll`.
@sharadkesarwani
Copy link
Contributor Author

Please implement support for list rolls and stop roll as well

Added support for list rolls and stop roll

@sharadkesarwani
Copy link
Contributor Author

please fix the review comments

Fixed all review comments.

@chandra1-n chandra1-n merged commit c32f7f6 into main Jan 24, 2024
10 checks passed
@chandra1-n chandra1-n deleted the SPOTAUT-17448-aks-cluster-roll branch January 24, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants