T report undefined corpora #20
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korp/cwb.py: - CWB.run_cqp: Add keyword argument "errors": if "report", report errors at the beginning of the output as lines beginning with "CQP Error:"; if "ignore", ignore errors; if "strict", throw CQPError (the default, as before).
korp/views/info.py: - /corpus_info: If the parameter "report_undefined_corpora" is true, add to the result the item "undefined_corpora" listing the undefined corpora in the parameter "corpus", instead of an error when a corpus is undefined. The configuration variable CHECK_AVAILABLE_CORPORA_STRICTLY controls how strictly the available corpora are checked.
korp/views/info.py: - /info: If the parameter "strict" is true, filter out undefined (inaccessible) corpora from the result.
|
This seems like a good improvement. The pull request is marked as a draft and therefore can't currently be merged. Are you planning on doing any further work on this, or should we just go ahead and merge it as it is? |
|
Great! My intention has been to augment the API documentation to cover the additions, but I haven’t got to doing that yet. I’ll also check if there was something else to do before converting this to a non-draft pull request. |
|
In fact, I’d prefer having #21 merged before this, so that it would be easier to add some tests for the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first PR of today's "Helsinki Hackathon":
This PR makes the backend more resilient to queries for missing corpora.
It also adds the option of a more verbose error message.
It adds the "strict" parameter to the backend API
WIP: this still needs to be documented.