Fix missing logo in pdfs when using svg format #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sprain
force-pushed
the
improve-svg-logo-behaviour
branch
from
bd836de to
df4c166
Compare
sprain
force-pushed
the
improve-svg-logo-behaviour
branch
from
df4c166 to
a3afabd
Compare
in order to contain this pr: endroid/qr-code#255
as the underlying version of endroid/qrcode requires at least PHP 7.2
sprain
force-pushed
the
improve-svg-logo-behaviour
branch
from
4c1ebac to
5c11b26
Compare
# Conflicts: # src/QrBill.php # tests/TestData/HtmlOutput/qr-additional-information.html # tests/TestData/HtmlOutput/qr-additional-information.print.html # tests/TestData/HtmlOutput/qr-alternative-schemes.html # tests/TestData/HtmlOutput/qr-alternative-schemes.print.html # tests/TestData/HtmlOutput/qr-full-set.html # tests/TestData/HtmlOutput/qr-full-set.print.html # tests/TestData/HtmlOutput/qr-minimal-setup.html # tests/TestData/HtmlOutput/qr-minimal-setup.print.html # tests/TestData/HtmlOutput/qr-payment-information-without-amount.html # tests/TestData/HtmlOutput/qr-payment-information-without-amount.print.html # tests/TestData/HtmlOutput/qr-payment-information-zero-amount.html # tests/TestData/HtmlOutput/qr-payment-information-zero-amount.print.html # tests/TestData/HtmlOutput/qr-payment-reference-non.html # tests/TestData/HtmlOutput/qr-payment-reference-non.print.html # tests/TestData/HtmlOutput/qr-payment-reference-scor.html # tests/TestData/HtmlOutput/qr-payment-reference-scor.print.html # tests/TestData/HtmlOutput/qr-ultimate-debtor.html # tests/TestData/HtmlOutput/qr-ultimate-debtor.print.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
endroid/qrcoderequires PHP 7.2 sind v3.6QrBill::SWISS_CROSS_LOGO_FILEis no longer publicly accessible. But I do not see any use case where this would or should have been used.