Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TcPdfOutput #53

Merged
merged 18 commits into from
Jun 26, 2020
Merged

Add TcPdfOutput #53

merged 18 commits into from
Jun 26, 2020

Conversation

sprain
Copy link
Owner

@sprain sprain commented Jun 20, 2020 •
edited
Loading

Resolves #50

  • Integrates TcPdfOutput into the library (as currently available as a separate project)
  • Improves setup of examples accordingly

Todos

@sprain sprain added the wip Work in progress label Jun 20, 2020
@sprain sprain mentioned this pull request Jun 20, 2020
Closed
@sdespont
Copy link
Contributor

Is it normal that some reference files have the placeholders and amounts ? Like qr-additional-information.pdf for example?

@sprain
Copy link
Owner Author

sprain commented Jun 22, 2020

Is it normal that some reference files have the placeholders and amounts ?

It‘s a valid use-case and therefore sprinkled into the tests :)

sdespont
sdespont reviewed Jun 24, 2020
View reviewed changes
Copy link
Contributor

@sdespont sdespont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tell me if you need help

src/PaymentPart/Output/TcPdfOutput/TcPdfOutput.php Outdated Show resolved Hide resolved
@sprain
Copy link
Owner Author

sprain commented Jun 24, 2020

Tell me if you need help

Thanks! I am currently busy with other things. I'll get back to this as soon as I can.

@sprain sprain mentioned this pull request Jun 24, 2020
Closed
@sprain
Copy link
Owner Author

sprain commented Jun 25, 2020 •
edited
Loading

@sdespont I fixed and simplified the handling of placeholders by using the official graphics. Any comments by you?
https://github.com/sprain/php-swiss-qr-bill/pull/53/files#diff-50f34ff1128cf60b1ac0ae7ad32d282bR255

Since file size is important to you: The finished pdf gains between 180 and 440 bytes by this change. But there were some elements missing before.

@sprain sprain removed the wip Work in progress label Jun 25, 2020
@sprain
Copy link
Owner Author

sprain commented Jun 25, 2020

@sdespont IMO this is now ready to merge. But I'd be happy to get your review first.

@sdespont
Copy link
Contributor

sdespont commented Jun 26, 2020 •
edited
Loading

@sprain OK for me, you can merge. Thanks for your work.

@sprain sprain merged commit a07d8a8 into master Jun 26, 2020
@sprain sprain deleted the add-tcpdf branch June 26, 2020 08:30
@sprain
Copy link
Owner Author

sprain commented Jun 26, 2020

v2.11 it is 😊
https://github.com/sprain/php-swiss-qr-bill/releases/tag/v2.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdespont sdespont sdespont left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New library to generate PDF documents using TCPDF
2 participants
@sprain @sdespont