Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump backstage to 1.31.1 #125

Merged
merged 4 commits into from
Sep 26, 2024
Merged

Bump backstage to 1.31.1 #125

merged 4 commits into from
Sep 26, 2024

Conversation

ivangonzalezacuna
Copy link
Collaborator

@ivangonzalezacuna ivangonzalezacuna commented Sep 24, 2024

Also took the chance and tried to bump the yarn version to 4.4.1, like suggested in the upgrade-helper and done in our instance as well.

However, this didn't shrink our yarn.lock file, but made it even bigger 😕 Also, there were some issues with commands like yarn tsc and so on, which I didn't really understood. I think I might have done it incorrectly, but I'm not sure.

The linting issues we are having in the pipelines can be reproducible by others: https://discord.com/channels/687207715902193673/1285669437223206983

Copy link

changeset-bot bot commented Sep 24, 2024

🦋 Changeset detected

Latest commit: 10f49e5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@spreadshirt/backstage-plugin-s3-viewer Patch
@spreadshirt/backstage-plugin-s3-viewer-backend Patch
@spreadshirt/backstage-plugin-s3-viewer-common Patch
@spreadshirt/backstage-plugin-s3-viewer-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ivangonzalezacuna ivangonzalezacuna requested review from heyLu and removed request for heyLu September 24, 2024 07:33
@heyLu
Copy link
Member

heyLu commented Sep 24, 2024

I think this project is still using Yarn 1 (as seen in pipeline logs like https://github.com/spreadshirt/backstage-plugin-s3/actions/runs/11009109121/job/30568059033?pr=125), thus the linting issues. I'm having a look at doing it locally according to https://yarnpkg.com/getting-started/install, will report back how that goes.

@heyLu heyLu mentioned this pull request Sep 24, 2024
@heyLu
Copy link
Member

heyLu commented Sep 24, 2024

Giving up for today, I tried a bunch of things, but always ended up getting the same error. If you like we can have a look together tomorrow.

@ivangonzalezacuna
Copy link
Collaborator Author

Giving up for today, I tried a bunch of things, but always ended up getting the same error. If you like we can have a look together tomorrow.

Yes, I ended up giving up as well. It was pretty confusing. Also, in the thread I linked above, the guy just said bumping to yarn4 fixed it for him. I'm quite confused about what can be wrong for us. But yes, we can give it a check together. Maybe also checking his repos and using them as reference, in case something is missing for us

@heyLu heyLu changed the title Bump backstage to latest version Bump backstage to 1.31.1 Sep 25, 2024
.gitignore Show resolved Hide resolved
.yarnrc.yml Show resolved Hide resolved
.changeset/rude-mangos-marry.md Show resolved Hide resolved
Along with the update, we also needed to bump "eslint" to the
latest version, otherwise the "yarn lint" command would fail due to missing modules.

Also needed to add "typescript" as dependency to make sure the "yarn tsc" command
would work. Might have been removed from other dependencies we had in the past.

Also ignore internal .yarn files for the prettier command
This has been done with the 'yarn up -R' command
@ivangonzalezacuna ivangonzalezacuna merged commit 3aea529 into main Sep 26, 2024
1 check passed
@ivangonzalezacuna ivangonzalezacuna deleted the bump-backstage branch September 26, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants