Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation fix: to saved_changes? #175

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Deprecation fix: to saved_changes? #175

wants to merge 2 commits into from

Conversation

joshRpowell
Copy link

Resolves:

DEPRECATION WARNING: The behavior of `changed?` inside of after callbacks will be changing in the next version of Rails. The new return value will ref
lect the behavior of calling the method after `save` returned (e.g. the opposite of what it returns now). To maintain the current behavior, use `saved
_changes?` instead. (called from update_inventory at /Users/jpowell/.gem/ruby/2.4.4/bundler/gems/spree-product-assembly-92ad5f4342a7/app/models/spree/
line_item_decorator.rb:43)

@joshRpowell
Copy link
Author

joshRpowell commented Apr 23, 2018 •
edited
Loading

CI fails on all Spree 3.2 which supports Rails 5.0. Green for Spree >= 3.3

Perhaps its worth versioning this Gem?

@joshRpowell joshRpowell closed this Sep 4, 2018
@joshRpowell joshRpowell reopened this Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@joshRpowell