upgrade to support spree v4.5 #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimsrung
commented
May 30, 2023
kimsrung
commented
- update spree version to 4.5
- update ruby 3.2.0
- fix test
kimsrung
force-pushed
the
update-spree-450
branch
3 times, most recently
from
e5c6ac0
to
209e9ba
Compare
spec/features/admin_spec.rb
Outdated
| @@ -19,6 +19,7 @@ | |||
| within("tr#review_#{review.id}") do | |||
| find('.approve').click | |||
| end | |||
| sleep(3) | |||
There was a problem hiding this comment.
What was the issue here? I think there are wait_for_turbo and wait_for_ajax helpers for specs, they may be helpful here
Gemfile
Outdated
| gem 'rails-controller-testing' | ||
| gem 'byebug' |
There was a problem hiding this comment.
I'm not sure if this one should be in the Gemfile (even if it's for development) - this is more of a utility, rather than something that's required for development
kimsrung
force-pushed
the
update-spree-450
branch
from
209e9ba
to
a9343f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.