Feature/rainbow gem #168
Merged
Feature/rainbow gem #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The colorize gem is licensed under GPL v2. While I sympathize with the goal of the copyleft licenses, including library code that's licensed under GPL can cause legal headaches. The console-colors gem seems to do the exact same thing. If replacing a GPL dependency with an MIT one isn't preferred, perhaps: 1. Remove the 2 calls to `.green` and 2 calls to `.red`, or 2. Use another gem's capability like [bundler][bundler] 3. Implement the red and green in this codebase [bundler]: https://github.com/bundler/bundler/blob/20f04aa8923c0d0f02e7a74d5e9609d772351668/lib/bundler/vendor/thor/lib/thor/shell/color.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.