Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SD-1361 Add destroy endpoint for basket in spree-api. #11149

Merged
merged 17 commits into from
Jul 28, 2021

Conversation

KacperMekarski
Copy link
Contributor

So far we could only empty the basket.
I'm also adding create service for spree-api cart#empty.

@viezly
Copy link

viezly bot commented Jul 13, 2021

Changes preview:

👀 Review pull request on Viezly

@KacperMekarski KacperMekarski marked this pull request as ready for review July 15, 2021 09:30
Copy link
Member

@damianlegawiec damianlegawiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core/app/models/spree/order.rb Outdated Show resolved Hide resolved
core/app/models/spree/order.rb Show resolved Hide resolved
core/app/models/spree/order.rb Outdated Show resolved Hide resolved
@damianlegawiec damianlegawiec added this to the 4.3 milestone Jul 15, 2021
@KacperMekarski KacperMekarski changed the title Add destroy endpoint for basket in spree-api. SD-1361 Add destroy endpoint for basket in spree-api. Jul 23, 2021
api/docs/v2/storefront/index.yaml Outdated Show resolved Hide resolved
api/docs/v2/storefront/index.yaml Outdated Show resolved Hide resolved
api/docs/v2/storefront/index.yaml Outdated Show resolved Hide resolved
api/docs/v2/storefront/index.yaml Outdated Show resolved Hide resolved
api/docs/v2/storefront/index.yaml Outdated Show resolved Hide resolved
core/app/services/spree/cart/destroy.rb Show resolved Hide resolved
core/config/locales/en.yml Outdated Show resolved Hide resolved
core/spec/models/spree/order_spec.rb Outdated Show resolved Hide resolved
@damianlegawiec damianlegawiec merged commit 45ac462 into master Jul 28, 2021
@delete-merged-branch delete-merged-branch bot deleted the add-destroy-basket-api-endpoint branch July 28, 2021 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants