Add support for Stripe Elements and Apple Pay (via Payment Request API) #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bbonislawski
commented
Jan 24, 2018
•
bbonislawski
commented
bbonislawski
force-pushed
the
use-stripe-elements
branch
from
a78a1c2
to
22773d1
Compare
|
@bbonislawski Is it valid? |
damianlegawiec
force-pushed
the
use-stripe-elements
branch
from
22773d1
to
3964c07
Compare
damianlegawiec
force-pushed
the
use-stripe-elements
branch
from
488b8b0
to
4277e47
Compare
damianlegawiec
changed the title
damianlegawiec
force-pushed
the
use-stripe-elements
branch
from
ae31bf0
to
4277e47
Compare
lib/controllers/frontend/spree/apple_pay_domain_verification_controller.rb
Outdated
Show resolved
Hide resolved
kushniryb
approved these changes
Jul 19, 2018
dimon-k
force-pushed
the
use-stripe-elements
branch
from
f99374f
to
728c38c
Compare
kushniryb
suggested changes
Jul 24, 2018
lib/controllers/frontend/spree/apple_pay_domain_verification_controller.rb
Outdated
Show resolved
Hide resolved
lib/controllers/frontend/spree/apple_pay_domain_verification_controller.rb
Outdated
Show resolved
Hide resolved
lib/views/frontend/spree/checkout/payment/_stripe_additional_info.html.erb
Outdated
Show resolved
Hide resolved
dimon-k
force-pushed
the
use-stripe-elements
branch
3 times, most recently
from
31f5dce
to
deabf2e
Compare
|
@damianlegawiec, locally all the tests are passing (no timeouts). Before my last changes, I had the same situation, I had to rebuild couple of times on travis, then it went through. Wanted to do the same now, but for some reason I cannot see a Rebuild button anymore. |
damianlegawiec
requested changes
Jul 30, 2018
dimon-k
force-pushed
the
use-stripe-elements
branch
2 times, most recently
from
cdf7a51
to
f7a648c
Compare
damianlegawiec
approved these changes
Sep 6, 2018
damianlegawiec
force-pushed
the
use-stripe-elements
branch
from
f7a648c
to
46ffade
Compare
damianlegawiec
force-pushed
the
use-stripe-elements
branch
from
46ffade
to
03252f4
Compare
btolarz
reviewed
Dec 11, 2018
lib/controllers/spree/apple_pay_domain_verification_controller.rb
Outdated
Show resolved
Hide resolved
| def apple_pay? | ||
| payment_method.is_a? Spree::Gateway::StripeApplePayGateway | ||
| end | ||
| end |
There was a problem hiding this comment.
It will be useful to also have a scope like from_credit_card but for apple pay payments
from_apple_pay for example
There was a problem hiding this comment.
@caudatecoder let's do it on another occasion :)
|
@caudatecoder I'm working on a tutorial for this and a demo app - but this is out of the scope of this repository :) |
nnande
approved these changes
Dec 11, 2018
btolarz
approved these changes
Dec 11, 2018
…verification_certificate as textarea
This change will allow to use this in applications not using the default Spree frontend. Also rewritten controller specs to request specs.
…y Domain Verification endpoint
kgorazd
approved these changes
Dec 11, 2018
damianlegawiec
force-pushed
the
use-stripe-elements
branch
from
db45151
to
0412072
Compare
caudatecoder
approved these changes
Dec 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.