This repository has been archived by the owner on Feb 23, 2020. It is now read-only.
Make update shipment handler accept inventory units #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a1c78bb, we updated the shipment serializer to push inventory units, so if we are updating, we should use them as well in case there is a variant mismatch as there is with exchanges If a shipment happens to be created using the add_shipment_handler instead of pushed with the serializer, even though that builds inventory units from the line items matching the shipment items skus, we should still be ok because it should match the inventory units similarly to how it previously matched line items.
|
it appears there is a single failing test on the shipment serializer, presumably introduced by 16e4cea |
added 3 commits
September 3, 2014 14:10
…ince that is what is generated in the serializer
…e shipment handler
|
Was this for master only? I think we made other branches also serialize inventory units instead of line items. Probably need to update the other branches as well I assume? |
|
@JDutil it appears the shipment serializer also uses inventory units on older versions as well, so this should probably be backported. |
JDutil
pushed a commit
that referenced
this pull request
Sep 16, 2014
In a1c78bb, we updated the shipment serializer to push inventory units, so if we are updating, we should use them as well in case there is a variant mismatch as there is with exchanges If a shipment happens to be created using the add_shipment_handler instead of pushed with the serializer, even though that builds inventory units from the line items matching the shipment items skus, we should still be ok because it should match the inventory units similarly to how it previously matched line items. Change update shipment handler to expect flattened inventory items, since that is what is generated in the serializer Make sure to cast quantity to an integer Handle multiple inventory units of the same sku and quantity in update shipment handler Fixes #39
JDutil
pushed a commit
that referenced
this pull request
Sep 16, 2014
In a1c78bb, we updated the shipment serializer to push inventory units, so if we are updating, we should use them as well in case there is a variant mismatch as there is with exchanges If a shipment happens to be created using the add_shipment_handler instead of pushed with the serializer, even though that builds inventory units from the line items matching the shipment items skus, we should still be ok because it should match the inventory units similarly to how it previously matched line items. Change update shipment handler to expect flattened inventory items, since that is what is generated in the serializer Make sure to cast quantity to an integer Handle multiple inventory units of the same sku and quantity in update shipment handler Fixes #39
|
Done as far back as is using IU Serializer |
|
👌 |
jordan-brough
pushed a commit
to jordan-brough/spree_wombat
that referenced
this pull request
Mar 4, 2015
Add more information to return items
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
a1c78bb,
we updated the shipment serializer to push inventory units, so if we are
updating, we should use them as well in case there is a variant mismatch
as there is with exchanges
If a shipment happens to be created using the add_shipment_handler
instead of pushed with the serializer, even though that builds inventory
units from the line items matching the shipment items skus, we should
still be ok because it should match the inventory units similarly to how
it previously matched line items.