Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated supervisor spec #119

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

rodrigues
Copy link
Contributor

Remove the deprecations listed below.

Elixir ~> 1.7, already specified in mix.exs as dependency, already includes the child specs: elixir-lang/elixir@43f80d3

warning: Supervisor.Spec.supervise/2 is deprecated. Use the new child specifications outlined in the Supervisor module instead
  lib/kaffe/consumer_group/group_member_supervisor.ex:63: Kaffe.GroupMemberSupervisor.init/1

warning: Supervisor.Spec.supervise/2 is deprecated. Use the new child specifications outlined in the Supervisor module instead
  lib/kaffe/consumer_group/worker/worker_supervisor.ex:36: Kaffe.WorkerSupervisor.init/1

warning: Supervisor.Spec.supervisor/2 is deprecated. Use the new child specifications outlined in the Supervisor module instead
  lib/kaffe/consumer_group/group_member_supervisor.ex:35: Kaffe.GroupMemberSupervisor.start_worker_supervisor/2

warning: Supervisor.Spec.worker/2 is deprecated. Use the new child specifications outlined in the Supervisor module instead
  lib/kaffe/consumer_group/worker/worker_supervisor.ex:14: Kaffe.WorkerSupervisor.start_worker_manager/2

warning: Supervisor.Spec.worker/2 is deprecated. Use the new child specifications outlined in the Supervisor module instead
  lib/kaffe/consumer_group/group_member_supervisor.ex:59: Kaffe.GroupMemberSupervisor.init/1

warning: Supervisor.Spec.worker/3 is deprecated. Use the new child specifications outlined in the Supervisor module instead
  lib/kaffe/consumer_group/worker/worker_supervisor.ex:22: Kaffe.WorkerSupervisor.start_worker/4

warning: Supervisor.Spec.worker/3 is deprecated. Use the new child specifications outlined in the Supervisor module instead
  lib/kaffe/consumer_group/group_member_supervisor.ex:47: Kaffe.GroupMemberSupervisor.start_group_member/5

Copy link
Contributor

@britth britth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @rodrigues ! 🌟

@britth britth merged commit bceba75 into spreedly:master Feb 10, 2022
@rodrigues rodrigues deleted the supervisor_childspec branch February 17, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants