Allow :already_present as a valid result from brod.create_client #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@d53dave Thanks! I'll check this out. |
|
Merged and published! |
tspenov
pushed a commit
to santiment/kaffe
that referenced
this pull request
Oct 25, 2019
Version is now 1.15.0. Closes spreedly#94
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kaffe currently chokes if it's trying to create a
brodclient but gets a{:error, :already_present}. This might be the case when there are connection problems to Kafka or thekaffeconsumer supervision tree is restarted (for whatever reason) and is, IMHO, not a failure case.