Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write some Unit-Tests #11

Open
spresnac opened this issue Oct 1, 2019 · 6 comments
Open

Write some Unit-Tests #11

spresnac opened this issue Oct 1, 2019 · 6 comments
Assignees
@dangenendt
Labels
Hacktoberfest

Comments

@spresnac
Copy link
Owner

spresnac commented Oct 1, 2019

It would be nice to have some unit tests for the client.
@spresnac
Copy link
Owner Author

spresnac commented Oct 1, 2019 via email •
edited
Loading

@dangenendt
Copy link
Contributor

I'll do it

@dangenendt
Copy link
Contributor

Is there anything against using a curl wrapper library like PHP Curl / Curl Easy? With one of those it would be easier to mock those curl-calls

@spresnac
Copy link
Owner Author

spresnac commented Oct 1, 2019

Is there anything against using a curl wrapper library like PHP Curl / Curl Easy? With one of those it would be easier to mock those curl-calls

I would like to keep it "as basic as possible" too prevend unneeded overhead (like this will come with librarys). So, please stay with curl ;)

dangenendt added a commit to dangenendt/logcrawler-client that referenced this issue Oct 1, 2019
@dangenendt
issue spresnac#11 - add unit tests
f3d98e8 
* code stylings
* add phpunit to project
* remove some dependencies from class
* move curl stuff to own class
dangenendt added a commit to dangenendt/logcrawler-client that referenced this issue Oct 1, 2019
@dangenendt
issue spresnac#11 - add unit tests
24bec93 
* code stylings
* use costants instead of magic strings/numbers
dangenendt added a commit to dangenendt/logcrawler-client that referenced this issue Oct 9, 2019
@dangenendt
issue spresnac#11 - add unit tests
0325911 
* refactored a little bit
@spresnac
Copy link
Owner Author

Hej @dangenendt , thank you for your efford. I first had merged your PR, but it turned out, that sending logs to the server is no more possibly with your changes. So i had to revert it back to normal (without your PR) to let work again.

@dangenendt
Copy link
Contributor

Damn. Sorry for that :(
Im on vacation now until next saturday... I will have a look into this again of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dangenendt dangenendt

Labels
Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spresnac @dangenendt