Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor WhisperAPI files for mocking #51

Merged
merged 5 commits into from
Nov 11, 2023
Merged

Refactor WhisperAPI files for mocking #51

merged 5 commits into from
Nov 11, 2023

Conversation

sprestrelski
Copy link
Owner

For #31

AllKeng
AllKeng approved these changes Nov 11, 2023
View reviewed changes
Copy link
Contributor

@AllKeng AllKeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing looks good. Has the mocking aspect.

kjanderson1
kjanderson1 approved these changes Nov 11, 2023
View reviewed changes
Copy link
Contributor

@kjanderson1 kjanderson1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@sprestrelski sprestrelski merged commit d300fee into main Nov 11, 2023
2 checks passed
@sprestrelski sprestrelski deleted the refactoringForTests branch November 11, 2023 23:07
@sprestrelski sprestrelski linked an issue Nov 13, 2023 that may be closed by this pull request
US5-5: Test to see if WhisperAPI correctly receives voice recording #31
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophianSulaiman ChristophianSulaiman ChristophianSulaiman approved these changes

@kjanderson1 kjanderson1 kjanderson1 approved these changes

@AllKeng AllKeng AllKeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

US5-5: Test to see if WhisperAPI correctly receives voice recording
4 participants
@sprestrelski @AllKeng @kjanderson1 @ChristophianSulaiman