This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
Fix the issue with special characters - Changed the default charset to UTF-8 to support special characters #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is to address the below reported issue |
chsraju
changed the title
|
Thanks @chsraju for contribution! Is it possible to also add a test that verifies this change? |
maciejwalkowiak
added
component: sns
maciejwalkowiak
suggested changes
Oct 6, 2020
| @@ -127,7 +126,7 @@ public InputStream getBody() throws IOException { | |||
|
|
|||
| private Charset getCharset() { | |||
| return this.mediaType.getCharset() != null ? this.mediaType.getCharset() | |||
| : Charset.forName(WebUtils.DEFAULT_CHARACTER_ENCODING); | |||
| : Charset.defaultCharset(); | |||
There was a problem hiding this comment.
This will use default charset from OS. According to SNS docs, strings are encoded with UTF-8 so perhaps instead we should use here StandardCharsets.UTF_8?
maciejwalkowiak
added
type: bug
maciejwalkowiak
pushed a commit
to awspring/spring-cloud-aws
that referenced
this pull request
Dec 19, 2020
Closes spring-attic/spring-cloud-aws#710 Closes spring-attic/spring-cloud-aws#660 Fixes spring-attic/spring-cloud-aws#645 Co-authored-by: Suresh Chintalapati <schintalapati@loc.gov>
juho9000
pushed a commit
to juho9000/spring-cloud-aws
that referenced
this pull request
Apr 29, 2021
Closes spring-attic/spring-cloud-aws#710 Closes spring-attic/spring-cloud-aws#660 Fixes spring-attic/spring-cloud-aws#645 Co-authored-by: Suresh Chintalapati <schintalapati@loc.gov>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the default charset to UTF-8 to support special characters