This repository has been archived by the owner on Feb 23, 2023. It is now read-only.
Register reflection configuration for custom Spring Data repository base class. #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ase class. This commit makes sure to read a potentially given custom repository base class implementation and register reflection configuration for it.
sdeleuze
reviewed
Dec 17, 2021
| return; | ||
| } | ||
|
|
||
| registry.reflection().forType(configuration.getCustomRepositoryBaseClass()).withAccess(TypeAccess.DECLARED_CONSTRUCTORS, TypeAccess.DECLARED_METHODS); |
There was a problem hiding this comment.
What about adding TypeAccess.PUBLIC_METHODS in order to have also the inherited ones?
There was a problem hiding this comment.
just public ones should actually do.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure to read a potentially given custom repository base class implementation and register reflection configuration for it.
Resolves: #1368