Skip to content
This repository was archived by the owner on Apr 5, 2022. It is now read-only.

Fixed id reuse (causing object overwrite) issue for inner objects defined in <constructor-arg> without an explicit id value. #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed id reuse (causing object overwrite) issue for inner objects defined in <constructor-arg> without an explicit id value. #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/springpython/config/_xml_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,8 @@ def _convert_bean(self, bean, prefix=""):
if "scope" in bean.attrib:
c.scope = scope.convert(bean.get("scope"))
self.logger.debug("bean: %s" % bean)
c.pos_constr = [self._convert_prop_def(bean, constr, bean.get("id") + ".constr") for constr in bean.findall(self.NS+"constructor-arg")]
c.pos_constr = [self._convert_prop_def(bean, constr, bean.get("id") + ".constr.{pos}".format(i))
for i, constr in enumerate(bean.findall(self.NS+"constructor-arg"))]
self.logger.debug("Constructors = %s" % c.pos_constr)
c.props = [self._convert_prop_def(bean, p, p.get("name")) for p in bean.findall(self.NS+"property")]

Expand Down Expand Up @@ -339,13 +340,13 @@ def _traverse_parents(self, leaf, child, ns, pos_constr,
def _get_pos_constr(self, object, ns):
""" Returns a list of all positional constructor arguments of an object.
"""
return [self._convert_prop_def(object, constr, object.get("id") + ".constr", ns) for constr in object.findall(ns+"constructor-arg")
if not "name" in constr.attrib]
return [self._convert_prop_def(object, constr, object.get("id") + ".constr.{pos}".format(i), ns)
for i, constr in enumerate(object.findall(ns+"constructor-arg")) if not "name" in constr.attrib]

def _get_named_constr(self, object, ns):
""" Returns a dictionary of all named constructor arguments of an object.
"""
return dict([(str(constr.get("name")), self._convert_prop_def(object, constr, object.get("id") + ".constr", ns))
return dict([(str(constr.get("name")), self._convert_prop_def(object, constr, object.get("id") + ".constr." + constr.get("name"), ns))
for constr in object.findall(ns+"constructor-arg") if "name" in constr.attrib])

def _get_props(self, object, ns):
Expand Down