Enables defining a base path for CredHub credentials #2521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kvmw <mshamsi@broadcom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When several instances of config-server using the same CredHub server, it is a common practice to separate each config-server credentials with a common base path.
For example, for given config-servers
fooandbar, we can have following paths in CredHub:/SERVER/FOO/secret/a/SERVER/FOO/secret/b/SERVER/BAR/secret/x/SERVER/BAR/secret/yThis approach even enables CredHub admins to limit access to those base paths to certain servers only. So server
foocan only access to credentials stored under/server/fooand serverbarcan only access credentials under/server/bar.This PR adds an optional CredHub property called
pathwhich should prepend to all credentials stored or retrieved by this config server. Default value is empty.