Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kotlin module uses different kotlin version than what boot provides, prevents boot 3.1 compatibility builds #1015

Closed
spencergibb opened this issue Mar 16, 2023 · 2 comments
Assignees
Labels
Milestone

Comments

@spencergibb
Copy link
Member

This causes build failures when testing compatibility with boot 3.1.x. It also sets the target jvm version to 1.8, it should be 17

<plugin>
<artifactId>kotlin-maven-plugin</artifactId>
<groupId>org.jetbrains.kotlin</groupId>
<version>1.6.0</version>
<configuration>
<args>
<arg>-Xjsr305=strict</arg>
</args>
<compilerPlugins>
<plugin>spring</plugin>
</compilerPlugins>
<jvmTarget>1.8</jvmTarget>
</configuration>
<executions>
<execution>
<id>test-compile</id>
<goals>
<goal>test-compile</goal>
</goals>
<configuration>
<sourceDirs>
<sourceDir>${project.basedir}/src/test/kotlin</sourceDir>
<sourceDir>${project.basedir}/src/test/java</sourceDir>
</sourceDirs>
<jvmTarget>1.8</jvmTarget>
</configuration>
</execution>
</executions>
<dependencies>
<dependency>
<groupId>org.jetbrains.kotlin</groupId>
<artifactId>kotlin-maven-allopen</artifactId>
<version>1.6.0</version>
</dependency>
</dependencies>
</plugin>

One potential issue is the use of kotlin-maven-allopen which I don't think is managed anywhere. Maybe we can ask the boot team to manage it?

Here is a similar change that gateway made spring-cloud/spring-cloud-gateway@4c4c6f3

@spencergibb spencergibb changed the title kotlin module uses different version than what boot provides kotlin module uses different version than what boot provides, prevents boot 3.1 compatibility builds Mar 16, 2023
@spencergibb spencergibb changed the title kotlin module uses different version than what boot provides, prevents boot 3.1 compatibility builds kotlin module uses different kotlin version than what boot provides, prevents boot 3.1 compatibility builds Mar 16, 2023
@olegz olegz added this to the 4.0.2 milestone Mar 17, 2023
@olegz olegz self-assigned this Mar 17, 2023
@olegz olegz closed this as completed in dac7d15 Mar 20, 2023
@spencergibb
Copy link
Member Author

Not sure upgrading to 1.8.10 is the right answer. Boot 3.0 uses 1.7.x. Will a boot 3.0 app work if this is compiled with 1.8.x?

@olegz
Copy link
Contributor

olegz commented Mar 20, 2023

I guess back to your original comment, i'd rather not to even include the version and have it managed higher up.

@olegz olegz reopened this Mar 20, 2023
olegz added a commit that referenced this issue Mar 20, 2023
olegz added a commit that referenced this issue Mar 20, 2023
GH-1015 Fix Kotlin dependencies
olegz added a commit that referenced this issue Apr 18, 2023
olegz added a commit that referenced this issue Apr 18, 2023
GH-1015 Fix Kotlin dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants