Fix Bug : RemoveCachedBodyFilter does not release direct memory correctly resulting in a memory leak #2969 #2971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spencergibb why hasn't this PR request been addressed yet? Is there any issue with it? |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2969
RemoveCachedBodyFilter uses the remove method to remove CACHED_REQUEST_BODY_ATTR from the exchange object, but it cannot guarantee that the dataBuffer will be released correctly.
When calling ServerWebExchangeUtils.cacheRequestBody multiple times in the project to generate a nested multi-layer ServerHttpRequestDecorator, it will cause a memory leak and eventually throw an OutOfDirectMemoryError
So in RemoveCachedBodyFilter, it should be ensured that the cached dataBuffer is released correctly.
This PR contains a fix for this problem. The idea is to ensure that databuf is released correctly by judging the return value of release.
Please review this PR, if looks ok please approve it.