To fix GH-2304 SaveSessionGatewayFilterFactory didn't work correctly #2997
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Team, I'm upgrading from Zuul to Spring Gateway for my project. But I found a bug in
SaveSessionGatewayFilterFactory
.Fixes GH-2304
The return type of
exchange.getSession().map(WebSession::save)
isMono<Mono<Void>>
I think this is a bug ,because the return value
WebSession::save
will never be consumed.