Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update HeaderRoutePredicateFactory to use getValuesAsList #3447

Closed

Conversation

ohprettyhak
Copy link
Contributor

This PR resolves #3446

@pivotal-cla
Copy link

@ohprettyhak Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@ohprettyhak Thank you for signing the Contributor License Agreement!

@spencergibb
Copy link
Member

Unfortunately you just added dozens of commits that aren't relevant

@ohprettyhak ohprettyhak force-pushed the fix-header-route-predicate branch from 43f8339 to d088c16 Compare September 25, 2024 17:50
@ohprettyhak
Copy link
Contributor Author

ohprettyhak commented Sep 25, 2024

Unfortunately you just added dozens of commits that aren't relevant

I'll fix it after I wake up.
done!

@ohprettyhak ohprettyhak deleted the fix-header-route-predicate branch September 27, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

HeaderRoutePredicateFactory fails to handle multiple header values correctly
4 participants