Upgrade eureka version

[holy12345]

Fixes #3255

[ryanjbaxter]

The build breaks with this change

[holy12345]

HI @ryanjbaxter

I see it and I will fix it. thanks

[codecov-io]

Codecov Report

Merging #3257 into master will increase coverage by 0.32%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##             master    #3257      +/-   ##
============================================
+ Coverage     65.46%   65.78%   +0.32%     
- Complexity     1475     1480       +5     
============================================
  Files           188      188              
  Lines          6943     6965      +22     
  Branches        846      847       +1     
============================================
+ Hits           4545     4582      +37     
+ Misses         2085     2069      -16     
- Partials        313      314       +1

Impacted Files	Coverage Δ	Complexity Δ
...x/eureka/server/EurekaServerAutoConfiguration.java	91.89% <100%> (ø)	16 <0> (ø)	⬇️
.../cloud/netflix/eureka/server/InstanceRegistry.java	81.25% <100%> (ø)	16 <0> (ø)	⬇️
.../netflix/eureka/server/EurekaServerConfigBean.java	22.04% <25%> (+0.26%)	33 <3> (+3)	⬆️
...flix/eureka/server/InstanceRegistryProperties.java	55.55% <50%> (ø)	3 <1> (ø)	⬇️
...x/ribbon/apache/HttpClientRibbonConfiguration.java	92.68% <0%> (-4.88%)	3% <0%> (ø)
...oud/netflix/zuul/filters/post/SendErrorFilter.java	72.72% <0%> (-3.64%)	16% <0%> (-1%)
...k/cloud/netflix/eureka/EurekaClientConfigBean.java	30.1% <0%> (+0.66%)	47% <0%> (+2%)	⬆️
...cloud/netflix/eureka/EurekaInstanceConfigBean.java	69.03% <0%> (+16.75%)	54% <0%> (+1%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6859b7a...e2e0aef. Read the comment docs.

[holy12345]

Hi @ryanjbaxter
I update the code. could you please help me review the code?
thanks

[ryanjbaxter]

Question regarding the changes

[holy12345]

Hi @ryanjbaxter thanks help me review :)

Let me explain details
EurekaServerConfigBean.java I add four private properties because EurekaServerConfig has add those.

Below in 1.9.4 eureka version :
initialCapacityOfResponseCache Associated PR: Netflix/eureka#1096

useAwsAsgApi Associated PR: Netflix/eureka#1108

expectedClientRenewalIntervalSeconds
Associated PR:Netflix/eureka#1093

myUrl Associated PR:Netflix/eureka#1107

On the other hand Eureka server use expectedNumberOfClientsSendingRenews replace expectedNumberOfRenewsPerMin. this is the reason why I change the InstanceRegistry.java and InstanceRegistryProperties.java and this PR you can see Netflix/eureka#1093

[ryanjbaxter]

Thanks I just wanted to make sure those default values were actually coming from somewhere and not being made up.

[ryanjbaxter]

@spencergibb do you think we should support the old property as well as new property to avoid breaking people that transition to Greenwich?

[MrMarkW]

That would be nice since it does break others, like this: https://github.com/twinformatics/eureka-consul-adapter

[ryanjbaxter]

@maximusfloydus could you open a separate issue?

[spencergibb]

#3286

[spencergibb]

Haha, I opened the issue and fixed it.

[holy12345]

Any update? thanks