Can we support readTimeout for ApacheHttpClient

[x-iron]

seems we only support readTimeout for okhttp, Can we support readTimeout for FeignAutoConfiguration:HttpClientFeignConfiguration:httpClient?

---

I just noticed we actually have per-request-default options which override the httpClient-default value:

public Options() {
  this(10, TimeUnit.SECONDS, 60, TimeUnit.SECONDS, true);
}

so I can use this as a workaround, but still want the httpClient level readTimeout :)

[OlgaMaciaszek]

HttpClientBuilder does not provide readTimeout property, however we could add setting socketTimeout and connectionRequestTimeout.

[jas34]

@OlgaMaciaszek if this is still needed to be worked upon then I would like to work on this.

[OlgaMaciaszek]

Hi @jas34, sure :). We are not planning to be adding many enhancements to this project anymore, since we've moved it into maintenance mode, but if you'd like to create a PR for this, we will review it.

[jas34]

@OlgaMaciaszek I can see:

1. socketTimeout is already existing in

   spring-cloud-openfeign/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/clientconfig/HttpClient5FeignConfiguration.java

   Line 81 in 07ded06

   SocketConfig.custom().setSoTimeout(Timeout.of(httpClientProperties.getHc5().getSocketTimeout(),

2. connectionRequestTimeout was added in PR connectionRequestTimeout for httpClient Fixes gh-799 #817

I do not think anything is needed against this ticket. Let me know if something is additionally expected.

[OlgaMaciaszek]

Right, it seems it was done in the meantime. Sorry for the confusion @jas34. Feel free to pick a different issue if you would like to add another contribution.

[OlgaMaciaszek]

Closing as already done.