Micrometer Observation API Support #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #793 +/- ##
============================================
- Coverage 78.57% 78.54% -0.03%
Complexity 552 552
============================================
Files 65 65
Lines 2007 2009 +2
Branches 282 283 +1
============================================
+ Hits 1577 1578 +1
Misses 268 268
- Partials 162 163 +1
|
spencergibb
reviewed
Nov 19, 2022
| @@ -57,9 +57,9 @@ | |||
| "defaultValue": "false" | |||
| }, | |||
| { | |||
| "name": "spring.cloud.openfeign.metrics.enabled", | |||
| "name": "spring.cloud.openfeign.micrometer.enabled", | |||
There was a problem hiding this comment.
Does the property name need to change?
There was a problem hiding this comment.
I think yes. I don't think metrics.enabled makes any sense when the users don't even have metrics, e.g.: they enable tracing but not metrics through the Observation API.
Or to put it in a different way: SC-OpenFeign has no idea what the user will configure in their ObservationRegistry.
marcingrzejszczak
approved these changes
Nov 19, 2022
OlgaMaciaszek
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change auto-configures
MicrometerObservationCapability. The previous auto-configuration forMicrometerCapabilityis still available but for thatMicrometerObservationCapabilityshould not be present (disabled, no observation registry, micrometer-observation is not on the classpath).Breaking change: properties were renamed from
spring.cloud.openfeign.metricstospring.cloud.openfeign.micrometer.Previous Micrometer support in SC-OpenFeign: #462
MicrometerObservationCapabilitysupport in Feign: OpenFeign/feign#1760