Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HandlerInterceptor section in document is outdated. TraceHandlerInterceptor disappeared. #2287

Closed
hojongs opened this issue May 16, 2023 · 2 comments · Fixed by #2288
Closed

HandlerInterceptor section in document is outdated. TraceHandlerInterceptor disappeared. #2287

hojongs opened this issue May 16, 2023 · 2 comments · Fixed by #2288
Labels
documentation status: first-timers-only An issue that can only be worked on by brand new contributors status: ideal-for-contribution An issue that a contributor can help us with
Milestone
3.1.9

Comments

@hojongs
Copy link
Contributor

hojongs commented May 16, 2023 •
edited
Loading

Describe the bug

https://github.com/spring-cloud/spring-cloud-sleuth/blob/a5eaa0ad6fabf94c60084eba44d7ba6a3401170f/docs/src/main/asciidoc/integrations.adoc#handlerinterceptor

In the document, TraceHandlerInterceptor is mentioned but it doesn't exist.

Since we want the span names to be precise, we use a TraceHandlerInterceptor that either wraps an existing HandlerInterceptor or is added directly to the list of existing HandlerInterceptors. ...
@marcingrzejszczak
Copy link
Contributor

Yikes! Are you willing to file a PR to remove this?

@marcingrzejszczak marcingrzejszczak added documentation status: first-timers-only An issue that can only be worked on by brand new contributors status: ideal-for-contribution An issue that a contributor can help us with labels May 16, 2023
@hojongs
Copy link
Contributor Author

hojongs commented May 16, 2023

Ok, let me make a PR. 😄

hojongs added a commit to hojongs/spring-cloud-sleuth that referenced this issue May 16, 2023
@hojongs
docs: Remove outdated HandlerInterceptor section
e3978a5 
TraceHandlerInterceptor doesn't exist.
Fixes spring-cloudgh-2287
@hojongs hojongs mentioned this issue May 16, 2023
Merged
@marcingrzejszczak marcingrzejszczak added this to the 3.1.9 milestone May 16, 2023
@github-project-automation github-project-automation bot moved this to Done in 2021.0.8 May 16, 2023
marcingrzejszczak pushed a commit that referenced this issue May 16, 2023
@hojongs
docs: Remove outdated HandlerInterceptor section (#2288)
44f8775 
TraceHandlerInterceptor doesn't exist.
Fixes gh-2287
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation status: first-timers-only An issue that can only be worked on by brand new contributors status: ideal-for-contribution An issue that a contributor can help us with
Projects
No open projects
2021.0.8
Status: Done
Milestone
3.1.9
Development

Successfully merging a pull request may close this issue.

docs: Remove outdated HandlerInterceptor section hojongs/spring-cloud-sleuth
2 participants
@marcingrzejszczak @hojongs