Integration with gRPC

[testark]

Is instrumentation for gRPC in your roadmap for anytime soon?

[marcingrzejszczak]

Nope - it's not ATM.

[ghost]

+1 for still implementing it :)

[sdavids]

Why is this closed?

[marcingrzejszczak]

Most likely by accident @sdavids

[thekalinga]

Is there a chance this would be fixed anytime soon?

gRPC is much more efficient as it uses HTTP 2.0, plus we can leverage new service mesh frameworks like Envoy that are far more superior & feature rich than Hystrix (netflix family ingeneral)

[codefromthecrypt]

#711 will resolve this indirectly or directly as brave supports grpc

[codefromthecrypt]

Let's see about more out-of-box integration

you can see tests for client and server interceptors here
https://github.com/openzipkin/brave/blob/master/instrumentation/grpc/src/test/java/brave/grpc/ITTracingClientInterceptor.java
https://github.com/openzipkin/brave/blob/master/instrumentation/grpc/src/test/java/brave/grpc/ITTracingServerInterceptor.java

there are probably some example spring boot + grpc projects out there.. key is doing the interceptor add-on conditionally when building server or client channel

[tkvangorder]

Since brave has client and server side interceptors for gRpc (thanks for the pointer @adriancole ), It is actually pretty straighforward to instrument gRcp calls by combining Spring Cloud Sleuth 2.x with the third-party boot library grpc-spring-boot-starter. I have setup a small sample project that demonstrates how this can be done here: https://github.com/tkvangorder/sleuth-grpc-sample

[spring-projects-issues]

Closing due to age of the question. If you would like us to look at this issue, please comment and we will look at re-opening the issue.

[ghost]

Thanks for still implementing it!