Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do Not Merge] Updated Spring Cloud Task to latest releases #348

Closed
wants to merge 1 commit into from

Conversation

cppwfs
Copy link
Collaborator

@cppwfs cppwfs commented Oct 31, 2017

Updated to remove all commons-logging-api dependencies to resolve logging issue.

Updated to handle 2.0.0.M3 Spring Cloud Stream

resovles #347

Updated to remove all commons-logging-api dependencies to resolve  logging issue.

Updated to handle 2.0.0.M3 Spring Cloud Stream

resovles spring-cloud#347
@cppwfs cppwfs added the in pr label Oct 31, 2017
@@ -49,16 +52,20 @@
@Autowired
protected MessageCollector collector;

ObjectMapper mapper = new ObjectMapper();
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this private

@cppwfs
Copy link
Collaborator Author

cppwfs commented Nov 1, 2017

Reviewed the PR with @mminella via chat. Updating PR with code review comments on Merge

@cppwfs
Copy link
Collaborator Author

cppwfs commented Nov 8, 2017

Closed. Already Merged under commit e279846

@cppwfs cppwfs closed this Nov 8, 2017
@cppwfs cppwfs removed the in pr label Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant