-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LeaseAwareVaultPropertySource no longer logs INFO messages during ConfigData bootstrap #565
Comments
If you would like us to spend some time helping you to diagnose the problem, please spend some time describing it and, ideally, providing a minimal sample that reproduces the problem. |
legacy.zip |
Thanks a lot. The issue is caused by the logging config not being configured yet at the time the Vault interaction is happening. You can use for now |
|
As it looks right now, the lifecycle is controlled from Spring Boot and we don't have any means to do anything useful here. It would make sense to follow up in https://github.com/spring-projects/spring-boot/issues. |
After consulting with the Boot Team, we could work around the logging issue by obtaining a specific logger that captures startup logs and prints these later on. |
I've opened an issue to help with this on the Boot side: spring-projects/spring-boot#24988. I think that's a prerequisite to fixing this as you need a |
Depends on spring-projects/spring-vault#636. |
…strap. We now reconfigure loggers through reflection of VaultPropertySource, SecretLeaseContainer and other components to obtain log events during the bootstrap. Closes gh-565.
After migrating to spring-boot-starter-parent 2.4.2 and spring-cloud-vault-config/spring-cloud-starter-vault-config 3.0.0 LeaseAwareVaultPropertySource no longer logs INFO messages if I intentionally add some non-existing Vault path to spring.config.import. I wanted to ask if it's by design or it's a bug.
The text was updated successfully, but these errors were encountered: