Add Micrometer tracing #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the required dependencies for Micrometer Tracing w/ the Brave bridge reporting to Wavefront or Zipkin. Resolves spring-cloud#553
artembilan
requested changes
Sep 4, 2024
It is already brought in transitively via prometheus-rsocket-spring.
artembilan
requested changes
Sep 4, 2024
onobc
commented
Sep 4, 2024
|
@onobc , looks like something is missing yet: https://github.com/spring-cloud/stream-applications/actions/runs/10707057201. Apparently the deps management must be not only in one place. Thanks |
Looking into it. I think the update I did w/ transitive dependency had a side effect as this was working locally. I will get it squared away and a fix submitted. Thanks for the review and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the required dependencies for Micrometer Tracing with the Brave bridge
with the ability to report trace to Zipkin or Wavefront.
Also the following unrelated commits are piggybacking:
Important
During merge please keep the commits separate as they are unrelated