Fix dependency mgmt in generated apps pom.xml #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous commit for adding Tracing attempted to use dependency management for the `prometheus-rsocket-spring` lib in the generated applications pom.xml. However, the app generator plugin assumes the dep mgmt is for a POM and adds tags for this which fails at runtime. This commit removes the dep. mgmt. for `prometheus-rsocket-spring` and instead specifies the version on the dependency. Also, the tracing property for Wavefront and Zipkin are updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous commit for adding Tracing attempted to use dependency management for the
prometheus-rsocket-springlib in the generated applications pom.xml. However, the app generator plugin assumes the dep mgmt is for a POM and adds tags for this which fails at runtime.This commit removes the dep. mgmt. for
prometheus-rsocket-springand instead specifies the version on the dependency.Also, the tracing property for Wavefront and Zipkin are updated.