Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo and improve description #34

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

zaerald
Copy link
Contributor

@zaerald zaerald commented Dec 29, 2021

This PR fixes the typo with "the the", and elaborated the description for @ComponentScan.

Motivation
For updating the description of @ComponentScan. Beginners, like me, uses Spring guides, and it was confusing as to why the com.example.testingweb package gets picked, and the reason it was picked as the package of the class annotated with @SpringBootApplication.

Feel free to correct me, to improve this part. This can also open new idea if we can add new macro (https://github.com/spring-guides/getting-started-macros) for the @SpringBootApplication annotation.
They could be found in other guides (not exhaustive list):

Copy link

@adilwahla adilwahla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks okay 👍

README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
@Buzzardo Buzzardo merged commit 51c0eb5 into spring-guides:main Oct 31, 2023
2 checks passed
@zaerald zaerald deleted the fix/typo branch November 4, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants